New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown rendering #1544
Markdown rendering #1544
Conversation
@notmd thank you for solving this. The only test case that fails is ordered lists (1., 2., etc.) are not rendering the numbers. The line spacing is also really big still in message blocks. Also, one thing that was discussed was to also render the Markdown when the user presses Review. Here is a diff that does this for your convenience: Git diff
Line spacing is interestingly not a problem for this Review rendering. So maybe there is an issue with the message block styling. |
@mashdragon Thank you for the feedback, I will check it again tomorrow. About render mark markdown when editing, I plan to make it in another PR and add auto grow feature to the textarea too. |
One other place that needs rendering is in the modals of the ranking task. I did not remember that before. |
avartarPosition="top" | ||
highlight={tree.id === messageId} | ||
></MessageTableEntry> | ||
{tree.children.length > 0 && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fix issue where the tree still display connection when it only have root (no children).
@mashdragon I just tweak style (heading space only) similar to boostrap which is the CSS framework Github use. Can you take a look at the style? |
I am not really sure what is the reason for the disabling css reset stuff / using chakra reset? but anyway looks good! |
Tailwind also reset style |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Follow up of #1544 Also fix #1657 - Add a preview tab just like Github when doing tasks. - Display preview markdown when clicking the review button. - Use [https://github.com/Andarist/react-textarea-autosize](https://github.com/Andarist/react-textarea-autosize) to make the textarea auto-grow when typing, so users don't need to scroll anymore. ![image](https://user-images.githubusercontent.com/33456881/219382379-5b29c0c9-d043-490b-97d8-473e1091da08.png)
close #1350 #837
Update: Ready to review now
Lightmode
Darkmode