Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: use default value in translation function #1638

Merged
merged 1 commit into from Feb 16, 2023
Merged

Refactoring: use default value in translation function #1638

merged 1 commit into from Feb 16, 2023

Conversation

GuilleHoardings
Copy link
Contributor

As suggested in this comment.

notmd
notmd approved these changes Feb 16, 2023
View reviewed changes
Copy link
Collaborator

@notmd notmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I don't the previous code work because t always has fallback by default

@notmd notmd merged commit 4cdd4bb into LAION-AI:main Feb 16, 2023
@GuilleHoardings GuilleHoardings deleted the i18n-default-value branch February 16, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmd notmd notmd approved these changes

@fozziethebeat fozziethebeat Awaiting requested review from fozziethebeat

@k-nearest-neighbor k-nearest-neighbor Awaiting requested review from k-nearest-neighbor

@AbdBarho AbdBarho Awaiting requested review from AbdBarho AbdBarho is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GuilleHoardings @notmd