Add charts and tables to the stats page #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuilleHoardings
requested review from
fozziethebeat,
k-nearest-neighbor,
AbdBarho and
notmd
as code owners
GuilleHoardings
force-pushed
the
mixed_stats
branch
2 times, most recently
from
20eb7f6
to
12dd7df
Compare
GuilleHoardings
force-pushed
the
mixed_stats
branch
from
12dd7df
to
adbdeaf
Compare
notmd
reviewed
Feb 18, 2023
rjmacarthy
reviewed
Feb 18, 2023
rjmacarthy
reviewed
Feb 18, 2023
rjmacarthy
reviewed
Feb 18, 2023
rjmacarthy
reviewed
Feb 18, 2023
rjmacarthy
reviewed
Feb 18, 2023
rjmacarthy
reviewed
Feb 18, 2023
|
Thanks for putting the work in to make the stats page more appealing it's looking great. I left some small comments for your consideration please let me know your thoughts on them. |
Thank you for your comments: they are very helpful. I will try to address all of them. |
GuilleHoardings
force-pushed
the
mixed_stats
branch
from
adbdeaf
to
92d139f
Compare
GuilleHoardings
force-pushed
the
mixed_stats
branch
from
92d139f
to
d6ba36d
Compare
GuilleHoardings
requested review from
AbdBarho and
notmd
and removed request for
k-nearest-neighbor,
AbdBarho and
notmd
AbdBarho
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
Unless @rjmacarthy has any comments, it all good from my side.
rjmacarthy
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1655, it's a mix of the graphs, added by @rjmacarthy, and the table, added by me. It looks like this:
I'm sure that many things could be improved in my code. Suggestions are welcome!