-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few more backend unit tests (trivial stuff) #1726
Open
bitplane
wants to merge
9
commits into
LAION-AI:main
Choose a base branch
from
bitplane:more-testing
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitplane
changed the title
A few more unit tests (trivial stuff)
A few more backend unit tests (trivial stuff)
Feb 18, 2023
Converted to draft for now, since some functions have been removed. I'll update in the next day or two |
bitplane
force-pushed
the
more-testing
branch
3 times, most recently
from
February 22, 2023 06:46
ba35948
to
1820d94
Compare
I changed the tests to do a simple test of the new cosine similarity functions, they're not great but still better than nothing. |
bitplane
force-pushed
the
more-testing
branch
from
February 28, 2023 11:20
1820d94
to
869eb6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just doing this bit by bit.
I've moved stuff about so it doesn't conflict with #605
Adds a bit more to #84 - it's some more examples and a bit more coverage, but doesn't actually run coverage or interfere with #605