Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Hindi and Japanese Translation #1738

Merged
merged 28 commits into from Feb 23, 2023
Merged

Conversation

shashankx86
Copy link
Contributor

No description provided.

@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@LarsEJonasson
Copy link
Contributor

In common.json line 43 and 44 are duplicate translations of "trollboard", and the first lacks the final quotation mark and comma.

In index.json line 4 lacks the final comma.

In labelling.json line 19 and 65 and lacks the final comma. Line 67 has quoted English terms, but JSON interprets the double quotation marks as a stop. Using escape sequences (a \ before each ") should work.

Line 5 in tos.json should not have a final comma.

@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

1 similar comment
@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@shashankx86
Copy link
Contributor Author

shashankx86 commented Feb 20, 2023

@LarsEJonasson all fixed and i also can translate to japanese but there isn't any jp folder should i do it?

@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@LarsEJonasson
Copy link
Contributor

@LarsEJonasson all fixed and i also can translate to japanese but there isn't any jp folder should i do it?

You still have some formatting issues with tasks.json. If you have Python you can run 'pre-commit run --all-files' on your local computer and it will correct them. For example the spaces between " and : are missing. You also have three initial spaces at each line, but it should be two.

As for more translations, the more the better.

@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@shashankx86
Copy link
Contributor Author

@LarsEJonasson Added jp translation

image

but here

image

@shashankx86 shashankx86 changed the title Translated to hindi and fixed old ones Added Hindi and Japanese Translation Feb 20, 2023
@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

2 similar comments
@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@@ -0,0 +1,79 @@
{
"accurate": "Точное",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the japanese files, if we don't have a translation now, then please use the english one, or remove entirely.

@shashankx86
Copy link
Contributor Author

@LarsEJonasson Done

some how jp/labelling.json got switch with ru/labelling.json
@shashankx86 shashankx86 requested review from AbdBarho and removed request for k-nearest-neighbor February 22, 2023 04:26
@GuilleHoardings
Copy link
Contributor

Japanese files should be under the ja directory, not jp.

Thank you for your contribution!

@shashankx86
Copy link
Contributor Author

Japanese files should be under the ja directory, not jp.

Do i need to fix it? @GuilleHoardings

@GuilleHoardings
Copy link
Contributor

I think that it doesn't work if you don't fix it. As far as I know, the framework looks in the directory that matches the locale, and the locale for Japan is ja. Have you tested it?

@shashankx86
Copy link
Contributor Author

shashankx86 commented Feb 22, 2023

I think that it doesn't work if you don't fix it. As far as I know, the framework looks in the directory that matches the locale, and the locale for Japan is ja. Have you tested it?

nope, I'm just renaming to ja

@shashankx86
Copy link
Contributor Author

@GuilleHoardings renamed to ja

@GuilleHoardings
Copy link
Contributor

Ok, thank you. I've received another proposal for the Japanase translation, and the submitter merged it with yours. I'll submit as an update when yours is merged.

@andreaskoepf andreaskoepf self-requested a review February 23, 2023 09:07
@andreaskoepf andreaskoepf merged commit a3508d2 into LAION-AI:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants