New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Hindi and Japanese Translation #1738
Conversation
❌ pre-commit failed. |
In common.json line 43 and 44 are duplicate translations of "trollboard", and the first lacks the final quotation mark and comma. In index.json line 4 lacks the final comma. In labelling.json line 19 and 65 and lacks the final comma. Line 67 has quoted English terms, but JSON interprets the double quotation marks as a stop. Using escape sequences (a \ before each ") should work. Line 5 in tos.json should not have a final comma. |
❌ pre-commit failed. |
❌ pre-commit failed. |
1 similar comment
❌ pre-commit failed. |
@LarsEJonasson all fixed and i also can translate to japanese but there isn't any jp folder should i do it? |
❌ pre-commit failed. |
You still have some formatting issues with tasks.json. If you have Python you can run 'pre-commit run --all-files' on your local computer and it will correct them. For example the spaces between " and : are missing. You also have three initial spaces at each line, but it should be two. As for more translations, the more the better. |
❌ pre-commit failed. |
❌ pre-commit failed. |
@LarsEJonasson Added jp translation but here |
❌ pre-commit failed. |
2 similar comments
❌ pre-commit failed. |
❌ pre-commit failed. |
@@ -0,0 +1,79 @@ | |||
{ | |||
"accurate": "Точное", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the japanese files, if we don't have a translation now, then please use the english one, or remove entirely.
@LarsEJonasson Done |
some how jp/labelling.json got switch with ru/labelling.json
Japanese files should be under the Thank you for your contribution! |
Do i need to fix it? @GuilleHoardings |
I think that it doesn't work if you don't fix it. As far as I know, the framework looks in the directory that matches the locale, and the locale for Japan is |
nope, I'm just renaming to ja |
@GuilleHoardings renamed to ja |
Ok, thank you. I've received another proposal for the Japanase translation, and the submitter merged it with yours. I'll submit as an update when yours is merged. |
No description provided.