Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement language as state instead of cookie #1785

Merged
merged 5 commits into from Feb 21, 2023
Merged

Conversation

notmd
Copy link
Collaborator

@notmd notmd commented Feb 21, 2023

close #1365 close #1662 close #1692 close #1530

  • Detect language from URL instead of cookie.

Steps to verify this.

  • In tab 1, choose a task in language en.
  • Open tab 2, change the language to a different one, and complete 1 task.
  • Back to tab 1 to finish the pending task. Verify that the next task and the UI are still in English.

This change is really critical, so be careful when deploying to production, better to test it in staging with our community first

@notmd
Copy link
Collaborator Author

notmd commented Feb 21, 2023

Pre-commit failure is not related to my change

Copy link
Collaborator

@AbdBarho AbdBarho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, hopefully we can close this problem once and for all.

website/.eslintrc.json Outdated Show resolved Hide resolved
website/src/pages/dashboard.tsx Show resolved Hide resolved
@LAION-AI LAION-AI deleted a comment from github-actions bot Feb 21, 2023
@LAION-AI LAION-AI deleted a comment from github-actions bot Feb 21, 2023
@LAION-AI LAION-AI deleted a comment from github-actions bot Feb 21, 2023
@LAION-AI LAION-AI deleted a comment from github-actions bot Feb 21, 2023
Copy link
Collaborator

@AbdBarho AbdBarho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the eslint rule, it looks good!

I cannot merge because of the pre-commit, we are gonna have to wait for it to be fixed on main, or someone with "admin" rights to force merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants