update pre-commit to use black 23.1.0 #1791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaskoepf
requested review from
andrewm4894,
olliestanley,
yk,
theblackcat102 and
sanagno
as code owners
yk
approved these changes
Feb 22, 2023
sanagno
approved these changes
Feb 22, 2023
olliestanley
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we ran into an interesting pre-commit loop:
pre-commit run --files oasst-shared/oasst_shared/schemas/inference.pysaid everything OKpre-commit run -awanted to re-format the file, but after adding the file pre-commit changed it's mind and wanted the old formatIn the hope to fix this I updated to black 23.1.0. The new black version wants to remove a couple of empty lines and parantheses.