Add button to copy code in markdown #1845
Conversation
Slowlife01
requested review from
fozziethebeat,
AbdBarho and
notmd
as code owners
| @@ -36,6 +38,7 @@ const sx: SystemStyleObject = { | |||
| bg: "gray.300", | |||
| p: 0.5, | |||
| borderRadius: "2px", | |||
| marginRight: "40px", | |||
There was a problem hiding this comment.
Also why you need marginRight here?
There was a problem hiding this comment.
I don't want the button to be hiding some text
There was a problem hiding this comment.
Maybe show the button when hover only like GitHub does, or maybe add margin to the code element only?
There was a problem hiding this comment.
also please try inset-block-end or inset-inline-end instead of margin-right for RTL languages.
There was a problem hiding this comment.
or maybe add margin to the code element only?
Is this not the right place to put it?
also please try inset-block-end or inset-inline-end instead of margin-right for RTL languages
Would this work instead? The inset-block-end and inset-inline-end don't seem to work for me
Also, is this how it's supposed to look like?
|
❌ pre-commit failed. |
Slowlife01
requested review from
andrewm4894,
olliestanley,
andreaskoepf and
yk
as code owners
|
❌ pre-commit failed. |
1 similar comment
|
❌ pre-commit failed. |
|
Something gone wrong there. Super sorry |
Resolves #1814
Not sure if using Toast is a bit too much but I think it fits the style