Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook contribution: Film descriptions. Resolves #1705 #1856

Merged
merged 6 commits into from Feb 25, 2023

Conversation

VictorLG98
Copy link
Contributor

README + Notebook to create a dataset of film descriptions with Q/A format. Resolves issue: #1705

@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@andrewm4894
Copy link
Collaborator

Cool!

Can you add an open in colab button like in here: https://github.com/LAION-AI/Open-Assistant/blob/main/notebooks/example/example.ipynb

And see if can run all cells so someone reading on GitHub can see some of the expected outputs. I see a comment saying a full run takes a long time so maybe see if can add in the stopping rule and someone if wanted to run all could then just comment it out or change it to really high number or something.

@VictorLG98
Copy link
Contributor Author

Cool!

Can you add an open in colab button like in here: https://github.com/LAION-AI/Open-Assistant/blob/main/notebooks/example/example.ipynb

And see if can run all cells so someone reading on GitHub can see some of the expected outputs. I see a comment saying a full run takes a long time so maybe see if can add in the stopping rule and someone if wanted to run all could then just comment it out or change it to really high number or something.

Done! Link button + debug rule added

@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@olliestanley olliestanley merged commit bae5e33 into LAION-AI:main Feb 25, 2023
@VictorLG98 VictorLG98 deleted the movie-description_development branch February 25, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants