Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TreeManagerConfiguration.max_prompt_lottery_waiting parameter #1889

Merged
merged 4 commits into from Feb 26, 2023

Conversation

andreaskoepf
Copy link
Collaborator

@andreaskoepf andreaskoepf commented Feb 26, 2023

  • add lang column to message_tree_state, create multi-column index on state, lang
  • stop generating initial prompt tasks for languages with more than max_prompt_lottery_waiting prompts in prompt_lottery_waiting state
  • add MAX_PROMPT_LOTTERY_WAITING workflow variable

@LarsEJonasson
Copy link
Contributor

Is 250 not a rather low value for max_prompt_lottery_waiting? It will not only block prompt generation for en and es, but also for de, fr, ru,ca,zh, pt-BR and th.

@andreaskoepf
Copy link
Collaborator Author

andreaskoepf commented Feb 26, 2023

Is 250 not a rather low value for max_prompt_lottery_waiting? It will not only block prompt generation for en and es, but also for de, fr, ru,ca,zh, pt-BR and th.

The value 250 is a default value that is only used when no corresponding environment variable is set.

The question is: Do we need more prompts currently and why? Or asked differently: When and why do we want to disable initial prompts for some languages?

In the beginning we had always a maximum of N trees (e.g. 100) that included initial prompts. Then after N trees were generated initial prompts only appeared sporadically after trees completed - people didn’t like it and demanded to be always able to submit initial prompts and as many as they like. We enabled this and introduced the prompt lottery… now we are at the point where the pendulum swung back and many people demand to stop initial prompts… and the question is 250 or 10k? I guess the idea is to nudge people towards writing assistant replies or labeling.

@andreaskoepf andreaskoepf mentioned this pull request Feb 26, 2023
@andreaskoepf andreaskoepf merged commit 097dd71 into main Feb 26, 2023
@andreaskoepf andreaskoepf deleted the limit_prompt_lottery_entries branch February 26, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants