Extended export script #1954
Merged
Extended export script #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yk
commented
Mar 3, 2023
yk
commented
- adds events (emojis, ratings, rankings) to export trees
- add anonymizer to anonymize user and message IDs in a stable way
andreaskoepf
reviewed
Mar 4, 2023
|
|
||
| return qry.all() | ||
|
|
||
|
|
||
| def get_events_for_messages(db: Session, message_ids: list[UUID]) -> dict[UUID, ExportMessageEvent]: | ||
| events = {} | ||
| emojis = db.query(MessageEmoji).filter(MessageEmoji.message_id.in_(message_ids)).all() |
There was a problem hiding this comment.
(We have to test this with the the production db size, I had similar code before for labels which I re-wrote after the query took > 0.5h to execute for 100k messages .. i.e. fetch_tree_messages_and_avg_labels function does the join now directly ...)
There was a problem hiding this comment.
fair point. let's test and see
andreaskoepf
reviewed
Mar 4, 2023
andreaskoepf
approved these changes
Mar 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.