Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added markdown tooltip #2064

Merged
merged 7 commits into from Mar 17, 2023
Merged

added markdown tooltip #2064

merged 7 commits into from Mar 17, 2023

Conversation

Anantha-Kandrapu
Copy link
Contributor

Issue #1919

Added a link to markdown syntax docs beside the progress bar :
[https://www.markdownguide.org/basic-syntax]

@notmd
Copy link
Collaborator

notmd commented Mar 14, 2023

Thanks, can you provide the screenshot?

@Anantha-Kandrapu
Copy link
Contributor Author

Anantha-Kandrapu commented Mar 14, 2023

Thanks, can you provide the screenshot?

image

The icon I added is to the right of progress bar.

improvements

I can add a label to the tooltip.
Change to a different icon .

@notmd
Copy link
Collaborator

notmd commented Mar 14, 2023

Can you make a design exactly like GitHub does? And the icon too.
image
Omit the button for now.

@Anantha-Kandrapu
Copy link
Contributor Author

Anantha-Kandrapu commented Mar 14, 2023

Can you make a design exactly like GitHub does? And the icon too. image Omit the button for now.

Sure. So I need to add the text icon + styling with markdown is supported and put the whole thing below the progress bar. right?

@notmd
Copy link
Collaborator

notmd commented Mar 14, 2023

Can you make a design exactly like GitHub does? And the icon too. image Omit the button for now.

Sure. So I need to add the text icon + styling with markdown is supported and put the whole thing below the progress bar. right?

Put to bottom it with position: "absolute" to the textarea. Just like Github does

@Anantha-Kandrapu
Copy link
Contributor Author

Can you make a design exactly like GitHub does? And the icon too. image Omit the button for now.

Sure. So I need to add the text icon + styling with markdown is supported and put the whole thing below the progress bar. right?

Put to bottom it with position: "absolute" to the textarea. Just like Github does

new

Is this good?

Copy link
Collaborator

@notmd notmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm

@olliestanley
Copy link
Collaborator

How come this changes the yarn.lock in the docs part of the project? Is that related to the website?

@notmd
Copy link
Collaborator

notmd commented Mar 16, 2023

How come this changes the yarn.lock in the docs part of the project? Is that related to the website?

It's not related. @Anantha-Kandrapu is there any reason why you update the yarn.lock file? If not can you revert the change?

@Anantha-Kandrapu
Copy link
Contributor Author

How come this changes the yarn.lock in the docs part of the project? Is that related to the website?

It's not related. @Anantha-Kandrapu is there any reason why you update the yarn.lock file? If not can you revert the change?

Sorry, I'll revert it.

@Anantha-Kandrapu
Copy link
Contributor Author

Anantha-Kandrapu commented Mar 16, 2023

How come this changes the yarn.lock in the docs part of the project? Is that related to the website?

It's not related. @Anantha-Kandrapu is there any reason why you update the yarn.lock file? If not can you revert the change?

I reverted the change by deleting the file in my local , downloading yarn.lock from OA main and pasting it.
Is there a better way to do this?

@notmd notmd merged commit c5eb105 into LAION-AI:main Mar 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants