Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub OAuth support to inference server #2097

Merged
merged 2 commits into from Mar 18, 2023

Conversation

olliestanley
Copy link
Collaborator

@olliestanley olliestanley commented Mar 17, 2023

As we are currently not allowing email authentication for the inference server it seems important to provide an alternative to Discord, which is not available in all countries. We will need to get a GitHub OAuth App client ID/secret for OA to fully enable this.

@AbdBarho
Copy link
Collaborator

I am thinking if it makes sense to add github login to the website.

linking accounts might be a bit of a problem, but should be possible.

@olliestanley
Copy link
Collaborator Author

I am thinking if it makes sense to add github login to the website.

linking accounts might be a bit of a problem, but should be possible.

Yeah, account linking is the thing. Will make it a bit annoying to handle moving the data collection app to full backend auth. Inference is a lot easier as we're using separate accounts I think

@AbdBarho
Copy link
Collaborator

Yeah, now that I think about it, even if we link the frontend accounts, we still need (a lot of) work to also link the accounts in the data backend.

Maybe linking won't be that easy....

In any case, if our users should be able to access the inference with their github account, and if this access should be available through our website, then we need to add github login support to the website.

Copy link
Collaborator

@yk yk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you!

@olliestanley olliestanley merged commit e348fcf into LAION-AI:main Mar 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants