Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Team page #2103

Merged
merged 8 commits into from Mar 19, 2023
Merged

Add Team page #2103

merged 8 commits into from Mar 19, 2023

Conversation

AbdBarho
Copy link
Collaborator

@AbdBarho AbdBarho commented Mar 17, 2023

Basic skeleton of the team page, will be improved upon later.

I did not add all people because that would take ages, I will write in discord after the PR is merged for the people to add themselves to the json.

image

Refs #1703

@AbdBarho AbdBarho marked this pull request as ready for review March 17, 2023 19:29
@AbdBarho AbdBarho changed the title Add contributors page Add Team page Mar 17, 2023
Copy link
Collaborator

@notmd notmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Have you considered loading other contributors using Github API?
Or we can use this instead https://contrib.rocks/preview?repo=angular%2Fangular-ja

website/src/pages/team.tsx Outdated Show resolved Hide resolved
@AbdBarho
Copy link
Collaborator Author

AbdBarho commented Mar 18, 2023

Nice. Have you considered loading other contributors using Github API? Or we can use this instead https://contrib.rocks/preview?repo=angular%2Fangular-ja

Yeah, this was discussed in #1703, the problem is that we have contributors who were never active on github, like moderators / legal team and stuff, and frankensteining a solution that works for both would be harder.

@LAION-AI LAION-AI deleted a comment from github-actions bot Mar 18, 2023
Copy link
Collaborator

@yk yk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@yk yk merged commit 7d24c4f into main Mar 19, 2023
4 checks passed
@yk yk deleted the team branch March 19, 2023 08:24
@yk
Copy link
Collaborator

yk commented Mar 19, 2023

merged this so we can inform people about the page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants