Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ghcr.io build for mulitplatform. includes Apple silicon #2151

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

melvinebenezer
Copy link
Collaborator

fixes #2081

Test Evidence:
Since this is a bit tricky to fix and test on this repo
I tested by building postgres images on my private repo actions.

@melvinebenezer melvinebenezer linked an issue Mar 21, 2023 that may be closed by this pull request
@melvinebenezer melvinebenezer self-assigned this Mar 21, 2023
Copy link
Collaborator

@andreaskoepf andreaskoepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, we'll have to observe what that impact is .. especially on build times.

@andreaskoepf
Copy link
Collaborator

@yk please merge if ok with you.

Copy link
Collaborator

@yk yk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good with me, thank you!

@andreaskoepf andreaskoepf merged commit fa4c42d into main Mar 24, 2023
@andreaskoepf andreaskoepf deleted the 2081-buildx-platform-args-broke-build branch March 24, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

buildx platform args broke build
3 participants