Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style updates to chat UI #2226

Merged
merged 2 commits into from
Mar 26, 2023
Merged

Style updates to chat UI #2226

merged 2 commits into from
Mar 26, 2023

Conversation

AbdBarho
Copy link
Collaborator

@AbdBarho AbdBarho commented Mar 26, 2023

  • limit width
  • move chat date to the end

image

@AbdBarho AbdBarho marked this pull request as ready for review March 26, 2023 08:35
@AbdBarho AbdBarho requested a review from notmd as a code owner March 26, 2023 08:35
Copy link
Collaborator

@notmd notmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the new UI is better. IMO it's more ugly than the current (I'm sorry). And changing the position of the message base on role is quite weird compared to other chat UI. Most chat UI out there align the message to the left and hight light the different base on color and avatar (user messages have the same color as the background and only highlight the assistant's message, cause most of users want to read the assistant's instead of their own message). And about the chat list, I'm planning to have a secondary sidebar (something like this https://minimals.cc/dashboard/chat) when I have time. So the user can quickly switch between chats. The main sidebar will be collapsed. IMO, OpenAI UI is really good, just missing a few features for better UX. But anyway, it's up to you.

@AbdBarho
Copy link
Collaborator Author

'm not sure the new UI is better. IMO it's more ugly than the current (I'm sorry). And changing the position of the message base on role is quite weird compared to other chat UI. Most chat UI out there align the message to the left and hight light the different base on color and avatar (user messages have the same color as the background and only highlight the assistant's message, cause most of users want to read the assistant's instead of their own message). And about the chat list, I'm planning to have a secondary sidebar (something like this https://minimals.cc/dashboard/chat) when I have time. So the user can quickly switch between chats. The main sidebar will be collapsed. IMO, OpenAI UI is really good, just missing a few features for better UX. But anyway, it's up to you.

Thank you for your feedback! no need to apologize, it is the reason why we create pull requests is to get feedback.

I can revert all the stuff to the chat conversation, I was also not 100% convinced, but for the dashboard it fixed a bug where the text would overflow past the container, which got me to fix the whole width thingy. Unless you are currently working on branch where this would create many conflicts?

What do you say? revert chat, keep dashboard?

@notmd
Copy link
Collaborator

notmd commented Mar 26, 2023

'm not sure the new UI is better. IMO it's more ugly than the current (I'm sorry). And changing the position of the message base on role is quite weird compared to other chat UI. Most chat UI out there align the message to the left and hight light the different base on color and avatar (user messages have the same color as the background and only highlight the assistant's message, cause most of users want to read the assistant's instead of their own message). And about the chat list, I'm planning to have a secondary sidebar (something like this https://minimals.cc/dashboard/chat) when I have time. So the user can quickly switch between chats. The main sidebar will be collapsed. IMO, OpenAI UI is really good, just missing a few features for better UX. But anyway, it's up to you.

Thank you for your feedback! no need to apologize, it is the reason why we create pull requests is to get feedback.

I can revert all the stuff to the chat conversation, I was also not 100% convinced, but for the dashboard it fixed a bug where the text would overflow past the container, which got me to fix the whole width thingy. Unless you are currently working on branch where this would create many conflicts?

What do you say? revert chat, keep dashboard?

Yeah let's keep the dashboard and revert the chat for now. I haven't started the work on new UI yet (will do when I have time)

@AbdBarho AbdBarho merged commit 000fb06 into main Mar 26, 2023
@AbdBarho AbdBarho deleted the chat-ui-styles branch March 26, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants