Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update warning and improve readme in model training #2246

Merged
merged 2 commits into from
Mar 27, 2023
Merged

update warning and improve readme in model training #2246

merged 2 commits into from
Mar 27, 2023

Conversation

CloseChoice
Copy link
Collaborator

closes #2148

  • Add installation instruction for oasst_data
  • Fix warning to point to the correct module
  • Add additional information in model/model_training/README.md for guidance

@sanagno sanagno enabled auto-merge (squash) March 27, 2023 20:09
@github-actions
Copy link

❌ pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@sanagno sanagno merged commit f6d03b4 into LAION-AI:main Mar 27, 2023
@CloseChoice CloseChoice deleted the ref/model-training-update-warning-improve-readme branch March 27, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanagno sanagno sanagno approved these changes

@theblackcat102 theblackcat102 Awaiting requested review from theblackcat102 theblackcat102 is a code owner

@dvruette dvruette Awaiting requested review from dvruette dvruette is a code owner

@andreaskoepf andreaskoepf Awaiting requested review from andreaskoepf andreaskoepf is a code owner

@yk yk Awaiting requested review from yk yk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No module named "oasst_data"
2 participants
@CloseChoice @sanagno