Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Correlation metrics for Reward Model" #2253

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Revert "Correlation metrics for Reward Model" #2253

merged 1 commit into from
Mar 28, 2023

Conversation

andreaskoepf
Copy link
Collaborator

Reverts #2251

theblackcat102
theblackcat102 approved these changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@theblackcat102 theblackcat102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for reverting. One problem for many PR was the PR has to be responsible for testing the code and shared wandb session if possible. The reviewer can't run all your PR code all the time.

@theblackcat102 theblackcat102 merged commit 9528a4c into main Mar 28, 2023
@theblackcat102 theblackcat102 deleted the revert-2251-rew-metrics branch March 28, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theblackcat102 theblackcat102 theblackcat102 approved these changes

@sanagno sanagno Awaiting requested review from sanagno sanagno is a code owner

@dvruette dvruette Awaiting requested review from dvruette dvruette is a code owner

@yk yk Awaiting requested review from yk yk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andreaskoepf @theblackcat102