Add support for Cerebras-GPT for training #2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olliestanley
requested review from
theblackcat102,
sanagno,
dvruette,
andreaskoepf and
yk
as code owners
model/model_training/utils.py
Outdated
| @@ -189,6 +190,9 @@ def get_tokenizer(conf) -> transformers.AutoTokenizer: | |||
| # explicitly specify LLaMATokenizer class until AutoTokenizer works | |||
| # assumes that the tokenizer config is stored in the same directory as the model weights | |||
| tokenizer = LLaMATokenizer.from_pretrained(conf.model_name) | |||
| elif "cerebras" in conf.model_name: | |||
| # Cerebras tokenizer for 13B is the tokenizer for all sizes | |||
There was a problem hiding this comment.
does this have to be specified? Are the other models released without a tokenizer-config? Otherwise this coud be removed .. the special handling for LLaMA was also removed already...
There was a problem hiding this comment.
13B is the only model which has an accompanying tokenizer uploaded to HuggingFace, so when removing this line and running with any size other than 13B we get an error saying, for e.g., could not find tokenizer cerebras/Cerebras-GPT-6.7B
There was a problem hiding this comment.
As part of resolving merge conflicts with the LLaMa change I have tweaked this and added a comment explaining why it is done
yk
pushed a commit
that referenced
this pull request
Apr 2, 2023
This adds configs for the 13B and 6.7B Cerebras models but with the necessary code changes made it should be easy enough to add configs for the smaller models too if desired. The tokenizer seems to be the GPT-2 fast tokenizer from HuggingFace so the special tokens have been configured for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds configs for the 13B and 6.7B Cerebras models but with the necessary code changes made it should be easy enough to add configs for the smaller models too if desired. The tokenizer seems to be the GPT-2 fast tokenizer from HuggingFace so the special tokens have been configured for that.