two more datasets #2301
Merged
two more datasets #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikegarts
requested review from
theblackcat102,
sanagno,
dvruette,
andreaskoepf and
yk
as code owners
mikegarts
commented
Apr 3, 2023
| return train, validation | ||
|
|
||
|
|
||
| def load_open_ai_summarize_from_feedback(): |
There was a problem hiding this comment.
Maybe it's better to just make the split manually here and in load_open_ai_summarize_from_feedback ?
I'm not sure what's best, but the default split seems to be not balanced in terms of sizes...
andreaskoepf
reviewed
Apr 3, 2023
| assert split in ("train", "test") | ||
| if sep_token is None: | ||
| sep_token = " . " | ||
|
|
||
| if mode == "rm": |
There was a problem hiding this comment.
This are changes in the reward/instructor folder. They are not used for the trainer_rm code. I suggest to remove these changes.
theblackcat102
pushed a commit
that referenced
this pull request
Apr 4, 2023
Reverts unrelated changes in `model/reward/instructor/rank_datasets.py` `AnthropicRLHF` class introduced by #2301.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.