Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix list index out of range error for soda dataset #2326

Merged
merged 12 commits into from Apr 10, 2023
Merged

fix list index out of range error for soda dataset #2326

merged 12 commits into from Apr 10, 2023

Conversation

CloseChoice
Copy link
Collaborator

  • fixed "index out of range" error in soda dataset
  • simplified the logic in the dataset preprocessing
  • added some plausibility checks
    @theblackcat102 I am pinging you here directly, since you created it. Would be good to get your feedback on this.

@andreaskoepf andreaskoepf added the ml label Apr 4, 2023
theblackcat102
theblackcat102 reviewed Apr 5, 2023
View reviewed changes
Copy link
Collaborator

@theblackcat102 theblackcat102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Apr 8, 2023

❌ pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

andreaskoepf
andreaskoepf approved these changes Apr 10, 2023
View reviewed changes
Copy link
Collaborator

@andreaskoepf andreaskoepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks a lot for adapting to latest sft & rl loader format!

@andreaskoepf andreaskoepf merged commit 3404e22 into LAION-AI:main Apr 10, 2023
1 check passed
@CloseChoice CloseChoice deleted the fix/soda-dataset branch April 10, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaskoepf andreaskoepf andreaskoepf approved these changes

@sanagno sanagno Awaiting requested review from sanagno sanagno is a code owner

@dvruette dvruette Awaiting requested review from dvruette dvruette is a code owner

@yk yk Awaiting requested review from yk yk is a code owner

@theblackcat102 theblackcat102 Awaiting requested review from theblackcat102 theblackcat102 is a code owner

Assignees
No one assigned
Labels
ml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CloseChoice @andreaskoepf @theblackcat102