Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chat deletion functionality #2350

Merged
merged 3 commits into from
Apr 8, 2023
Merged

Add chat deletion functionality #2350

merged 3 commits into from
Apr 8, 2023

Conversation

AbdBarho
Copy link
Collaborator

@AbdBarho AbdBarho commented Apr 6, 2023

Allow users to delete their own chats

Maybe some python wizard can clean up the monstrosity of query I wrote for deletion, I could not get the chat deletion to cascade, so I had to clear the messages first.

@notmd
Copy link
Collaborator

notmd commented Apr 6, 2023

Can we make it soft delete instead?

@AbdBarho
Copy link
Collaborator Author

AbdBarho commented Apr 6, 2023

Can we make it soft delete instead?

We can, I am not sure if GDPR would be happy about it, unless we have it in our terms of service.

@LAION-AI LAION-AI deleted a comment from github-actions bot Apr 6, 2023
@notmd
Copy link
Collaborator

notmd commented Apr 6, 2023

Be careful when merging this, it will delete messages that we will use for RL. we better remove the foreign key or soft delete the message.

@olliestanley
Copy link
Collaborator

Be careful when merging this, it will delete messages that we will use for RL. we better remove the foreign key or soft delete the message.

I see the logic to favour soft deletion but I would be concerned about people not being able to delete their data fully if they accidentally input private/compromising info

@notmd
Copy link
Collaborator

notmd commented Apr 6, 2023

I see the logic to favour soft deletion but I would be concerned about people not being able to delete their data fully if they accidentally input private/compromising info

Yeah, we should ask the user for this. But for me, most of the time I want to delete all the chats because I want to make it easier to manage chats (I believe many other users would do the same). If we always delete messages, we wont get any data to improve the model.

Copy link
Collaborator

@notmd notmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

web changes LGTM, but we better discuss this before merging the PR

@olliestanley olliestanley linked an issue Apr 7, 2023 that may be closed by this pull request
@AbdBarho AbdBarho removed a link to an issue Apr 8, 2023
@AbdBarho
Copy link
Collaborator Author

AbdBarho commented Apr 8, 2023

I am going to merge this one with the functionality disabled, meaning the user still can't delete, but the code is there.

I think we should add the "hide" option first, then enable this one.

I unlinked the issues.

@AbdBarho AbdBarho merged commit 80a2b21 into main Apr 8, 2023
@AbdBarho AbdBarho deleted the chat-delete branch April 8, 2023 07:45
@olliestanley
Copy link
Collaborator

I am going to merge this one with the functionality disabled, meaning the user still can't delete, but the code is there.

I think we should add the "hide" option first, then enable this one.

I unlinked the issues.

I think we should also make sure the "hide" option is clearer and easier to click in the UI when we do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants