-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vicuna dataset #2364
Merged
andreaskoepf
merged 6 commits into
LAION-AI:main
from
CloseChoice:feature/vicuna-dataset
Apr 7, 2023
Merged
Add vicuna dataset #2364
andreaskoepf
merged 6 commits into
LAION-AI:main
from
CloseChoice:feature/vicuna-dataset
Apr 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloseChoice
commented
Apr 7, 2023
CloseChoice
commented
Apr 7, 2023
andreaskoepf
reviewed
Apr 7, 2023
andreaskoepf
requested changes
Apr 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just minor formatting change requested.
andreaskoepf
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2341
This PR adds the vicuna dataset. We use the filtered vicuna dataset since it only contains english conversations.
The sanity checks are necessary here and filter quite a number of IMO unuseful conversations (where the conversation is empty, where we have less than 2 speakers and where the speakers are not in adjacent order). After all filterings we are left with 84260 of 85071 conversations.