Google auth website #2391
Merged
Google auth website #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdBarho
force-pushed
the
google-auth-website
branch
from
2006e7c
to
c115ccd
Compare
AbdBarho
force-pushed
the
google-auth-website
branch
from
3b895cd
to
fdfa345
Compare
AbdBarho
commented
Apr 14, 2023
| @@ -51,7 +52,8 @@ const ManageUser = ({ user }: InferGetServerSidePropsType<typeof getServerSidePr | |||
| const toast = useToast(); | |||
|
|
|||
| const { data: stats } = uswSWRImmutable<Partial<{ [time in LeaderboardTimeFrame]: LeaderboardEntity }>>( | |||
| "/api/user_stats?uid=" + user.id, | |||
| "/api/user_stats?" + | |||
| new URLSearchParams({ id: user.id, auth_method: user.auth_method, display_name: user.display_name }), | |||
There was a problem hiding this comment.
fix a bug we already have now:
if you go to the prod deployment / admin / open a user that is logged in with discord, the stats are missing at the bottom.
There was a problem hiding this comment.
Notice that as well, but I'm too lazy to fix it lol
notmd
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add google login to website
lucide Icons has no Google icon, and as it turns out, they don't allow any new branch icons lucide-icons/lucide#670 and will be removing old ones.
So only for logos of brands, we can use this new library, otherwise we stick to lucide