Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix update chat visibility #2566

Merged
merged 1 commit into from Apr 16, 2023
Merged

Fix update chat visibility #2566

merged 1 commit into from Apr 16, 2023

Conversation

notmd
Copy link
Collaborator

@notmd notmd commented Apr 15, 2023 •
edited

Axios send data as body instead query. I can change to send as query instead, but I think send as body is more consistent.
cc @yk

@notmd notmd changed the title Fix chat visibility Fix update chat visibility Apr 15, 2023
yk
yk approved these changes Apr 15, 2023
View reviewed changes
Copy link
Collaborator

@yk yk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you!

@AbdBarho AbdBarho merged commit e2074b2 into main Apr 16, 2023
4 checks passed
@AbdBarho AbdBarho deleted the fix_chat_visibility branch April 16, 2023 06:06
@notmd notmd mentioned this pull request Apr 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yk yk yk approved these changes

@AbdBarho AbdBarho AbdBarho approved these changes

@andreaskoepf andreaskoepf Awaiting requested review from andreaskoepf andreaskoepf is a code owner

@olliestanley olliestanley Awaiting requested review from olliestanley olliestanley is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@notmd @yk @AbdBarho