Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grading page wip and homepage #26

Merged
merged 8 commits into from Dec 19, 2022
Merged

Grading page wip and homepage #26

merged 8 commits into from Dec 19, 2022

Conversation

k-nearest-neighbor
Copy link
Collaborator

  • Grading prototype FE at /grading/grade-output
  • Homepage
  • Typescript
  • Move sources under src
  • A few common components

This is a larger PR because of some boilerplate operations and things like switching to .tsx. Normally I would have a smaller and more focused PR.

andreaskoepf
andreaskoepf reviewed Dec 18, 2022
View reviewed changes
website/src/index.css Outdated Show resolved Hide resolved
andreaskoepf
andreaskoepf reviewed Dec 18, 2022
View reviewed changes
website/src/index.js Outdated Show resolved Hide resolved
andreaskoepf
andreaskoepf requested changes Dec 18, 2022
View reviewed changes
Copy link
Collaborator

@andreaskoepf andreaskoepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will the empty website/src/styles/Home.module.css be used later, is it required?

andreaskoepf
andreaskoepf approved these changes Dec 18, 2022
View reviewed changes
Copy link
Collaborator

@andreaskoepf andreaskoepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

fozziethebeat
fozziethebeat reviewed Dec 18, 2022
View reviewed changes
Copy link
Collaborator

@fozziethebeat fozziethebeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks really good. Can you change the two auth steps to use the next-auth-js method so that we're able to run without any external auth providers? (this will implicitly change how the login page is handled but we can do that in a later change).

website/src/pages/_app.tsx Outdated Show resolved Hide resolved
website/src/pages/index.tsx Outdated Show resolved Hide resolved
@fozziethebeat fozziethebeat merged commit 00ad927 into LAION-AI:main Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fozziethebeat fozziethebeat fozziethebeat approved these changes

@andreaskoepf andreaskoepf andreaskoepf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@k-nearest-neighbor @fozziethebeat @andreaskoepf @i-like-apis