Website e2e tests #266
Merged
Website e2e tests #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
othrayte
requested review from
fozziethebeat,
k-nearest-neighbor and
AbdBarho
as code owners
fozziethebeat
requested changes
Jan 2, 2023
Fixed issue where existing sign in test fails due to the existence of dev test login. Added reusable cy.signInWithEmail() to login before testing rest of UI.
These are intended to function as a minimal smoke test that the API interaction with the backend is functional.
Like the previous commit, these are intended to function as a minimal smoke test that the API interaction with the backend is functional.
othrayte
force-pushed
the
website-e2e-tests
branch
from
bfbf9e9
to
dc1af6e
Compare
fozziethebeat
approved these changes
Jan 2, 2023
|
This looks really good and simple! Before closing out the bug, can you add some README documentation in a follow up PR so that other's know how to setup a test (and how to insert the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some end to end tests of website functionality, these ones are desired to function as smoke tests that check that interaction with the backend is functioning, #181. In think there is a question here about whether this PR completes #181 or is just a step towards it.
At the moment there is limited ability to check that things are actually succeeding and that is something that we probably want to look more into. For example when submitting a new user reply there isn't a clear way to prove that the reply was recorded, even if we interact directly with the backend. If anyone has suggestions here it could greatly improve the quality of the tests.
Secondly I've designed these e2e tests as a minimal "smoke" test of the API interaction with the backend rather than a comprehensive test of all website<->backend API interactions as that will probably be handled more performantly using the proposed contract tests from #204 (which I admit to not knowing much about).
Note, there is a bit of duplication between some of the task pages and between their e2e tests, maybe that is something we can look at refactoring later.