Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create api_client class to call backend, partial bot rewrite #27

Merged
merged 2 commits into from Dec 19, 2022

Conversation

andreaskoepf
Copy link
Collaborator

Basic bot communication works, but we need to decide how the bot-user interaction really works.
Currently I have implemented a dummy time base protocol which sends messages in a bot channel.
Maybe it is better to go with commands to initialize actions.

But then we still need an intuitive way to interact with the bot.

Copy link
Collaborator

@yk yk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Some things to improve (but can be done later):

  • use httpx instead of requests for async i/o
  • logging instead of prints
  • general cleanup, including sharing code between bot and backend (I'll take that)

@andreaskoepf andreaskoepf merged commit 3a370c9 into main Dec 19, 2022
@andreaskoepf andreaskoepf deleted the bot_new_api branch December 19, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants