fix: added option to specify platform for db in compose #2725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiquegarmier
requested review from
andreaskoepf,
melvinebenezer,
yk,
olliestanley,
AbdBarho and
notmd
as code owners
melvinebenezer
approved these changes
Apr 19, 2023
andreaskoepf
approved these changes
Apr 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to issue #2721
enables specifying platform for service
dbusing environment variableDB_PLATFORM. If left unspecified (silently) defaults to current behaviour.this solves the issue where M1 users where unable to use docker-compose as the
dbservice relies onghcr.io/laion-ai/open-assistant/oasst-postgres(which does not supportlinux/arm64/v8as plaform).sadly (afaik) docker-compose does not offer something akin to
docker --platformyou have to set it in the compose-file.