Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update entities #2809

Merged
merged 3 commits into from
Apr 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions model/model_training/custom_datasets/entities.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
from enum import Enum


class Mode(Enum):
sft = "sft"
rm = "rm"
rl = "rl"
22 changes: 15 additions & 7 deletions model/model_training/custom_datasets/formatting.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
from itertools import zip_longest
from random import shuffle

from model_training.custom_datasets.entities import Language, Mode
from langcodes import Language
from model_training.custom_datasets.entities import Mode
from pydantic import BaseModel, validator
from pydantic.fields import ModelField

Expand All @@ -25,12 +26,19 @@ def format_system_prefix(prefix, eos_token):
class DatasetEntry(BaseModel):
questions: list[str]
answers: list[str]
context: str | None
lang: Language | None
length: int | None
quality: float | None
humor: float | None
creativity: float | None
context: str | None = None
lang: str | None = None
length: int | None = None
quality: float | None = None
humor: float | None = None
creativity: float | None = None

@validator("lang")
def valid_lang(cls, v) -> str | None:
if v is not None:
if not (lang := Language.get(v)).is_valid():
raise ValueError(f"Language {v} is not valid. Please provide BCP 47 compatible language codes.")
return str(lang)

@validator("length")
def above_zero(cls, v) -> int:
Expand Down
5 changes: 3 additions & 2 deletions model/model_training/tests/test_formatting.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import pytest
from model_training.custom_datasets.entities import Language, Mode
from langcodes import Language
from model_training.custom_datasets.entities import Mode
from model_training.custom_datasets.formatting import QA_SPECIAL_TOKENS, DatasetEntry


Expand Down Expand Up @@ -29,7 +30,7 @@ def test_dataset_entry():
questions=["What is the capital of France?"],
answers=["The capital of France is Paris."],
context="Some context",
lang=Language("en"),
lang="en",
length=100,
quality=1.0,
humor=0.0,
Expand Down
1 change: 1 addition & 0 deletions model/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ dependencies = [
"sentencepiece==0.1.97",
"scikit-learn==1.2.0",
"tokenizers==0.13.2",
"langcodes==3.3.0",
"torch==1.13.1",
"tqdm==4.65.0",
"pydantic==1.10.7",
Expand Down