Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xor_codec script (thanks Mick) #2824

Merged
merged 1 commit into from Apr 22, 2023
Merged

Add xor_codec script (thanks Mick) #2824

merged 1 commit into from Apr 22, 2023

Conversation

olliestanley
Copy link
Collaborator

@olliestanley olliestanley commented Apr 21, 2023

Original PR history was broken.

Encode: xor_codec.py output_dir/ model_dir/ llama_dir/ --encode
Decode: xor_codec.py output_dir/ delta_dir/ llama_dir/


Co-authored-by: umbra-scientia 44982143+umbra-scientia@users.noreply.github.com

@olliestanley olliestanley marked this pull request as ready for review April 21, 2023 23:31
@olliestanley olliestanley enabled auto-merge (squash) April 21, 2023 23:31
@umbra-scientia
Copy link
Contributor

Lets skip this PR and use this one instead: #2829

The simple XOR format is too finicky and users are having problems with minor differences in HuggingFace and PyTorch versions. The new script is designed to be immune to or graceful with those details.

@olliestanley olliestanley enabled auto-merge (squash) April 22, 2023 15:59
@olliestanley olliestanley enabled auto-merge (squash) April 22, 2023 15:59
@olliestanley olliestanley changed the title Add xor_codec script Add xor_codec script (thanks Mick) Apr 22, 2023
Copy link
Collaborator

@andreaskoepf andreaskoepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also thanks for testing and getting the llama xor task done...!

@olliestanley olliestanley merged commit cf0ba2f into main Apr 22, 2023
1 check passed
@olliestanley olliestanley deleted the add-xor-codec-script branch April 22, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants