Joke explanation generalization #2899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampatkalyan
requested review from
theblackcat102,
sanagno,
dvruette,
andreaskoepf and
yk
as code owners
CloseChoice
reviewed
Apr 25, 2023
| @@ -343,16 +343,16 @@ def __init__(self, cache_dir) -> None: | |||
| # DO NOT change this | |||
| # its the data that had syntax error | |||
| explanation = data["explaination"] | |||
| self.pairs.append((joke, explanation)) | |||
| self.pairs.append(DatasetEntry([joke], [explanation])) | |||
There was a problem hiding this comment.
you rely here on the order of the keywords. Could we make this explicit by using
Suggested change
| self.pairs.append(DatasetEntry([joke], [explanation])) | |
| self.pairs.append(DatasetEntry(questions=[joke], answers=[explanation])) |
There was a problem hiding this comment.
Will fix it. Thank you
| @@ -610,6 +610,6 @@ def _process_instruction(self, row: dict[str, str], input_max_length: int) -> Da | |||
| def __len__(self) -> int: | |||
| return len(self.rows) | |||
|
|
|||
| def __getitem__(self, index: int) -> list[str] | tuple[str]: | |||
| def __getitem__(self, index: int) -> DatasetEntry: | |||
Added named parameters while creating DatasetEntry objects. Removed redundant variables like question and answer and the if condition in __init__function which depended on question and answer which is never used or changed.
andreaskoepf
approved these changes
Apr 27, 2023
grgau
pushed a commit
to grgau/Open-Assistant
that referenced
this pull request
May 8, 2023
For the Issue LAION-AI#2827. I have made changes to JokeExplaniation Class. This PR implements the DatasetEntry class in the JokeExplaination class to generalize the data. The DatasetEntry class provides a consistent data structure for storing joke-explanation pairs, making it easier to work with the data. and made changes in AlpacaGpt4 to correct the annotation in one of its methods. The changes in this PR include: - Adding a new DatasetEntry class to represent joke-explanation pairs - Updating the JokeExplaination class to use DatasetEntry objects to store data - Replacing the AlpacaGpt4 class __getitem__ method with correct annotation --------- Co-authored-by: sampatkalyan <120446217+Andavarapu-Sampat-Kalyan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the Issue #2827.
I have made changes to JokeExplaniation Class.
This PR implements the DatasetEntry class in the JokeExplaination class to generalize the data. The DatasetEntry class provides a consistent data structure for storing joke-explanation pairs, making it easier to work with the data.
and made changes in AlpacaGpt4 to correct the annotation in one of its methods.
The changes in this PR include: