Admin interface: Change display name (#2849) #2908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeanChugall
requested review from
andreaskoepf,
melvinebenezer,
yk,
AbdBarho and
notmd
as code owners
notmd
approved these changes
Apr 26, 2023
melvinebenezer
approved these changes
Apr 27, 2023
grgau
pushed a commit
to grgau/Open-Assistant
that referenced
this pull request
May 8, 2023
### Hello 馃憢, I hope you're doing great! I'm delighted to submit this pull request for enhancing the admin interface LAION-AI#2849 by adding the ability to change the display name of users. ## 馃専 Changes Made Below is a summary of the changes I've made in this PR: ### FRONTEND: --- - ```[id].tsx``` - remove ```isDisabled``` from FormControl. - ```oasst_api_client.ts``` - change API PUT url in ```set_user_status``` method to accept ```display_name``` parameter. - ```update_user.tsx``` add ```display_name``` parameter. ### BACKEND: --- - ```user.py``` -> update ```update_user``` function signature *(added ```display_name: Optional[str] = None```) - ```user_repository.py``` update ```update_user``` function signature *(added ```display_name: Optional[str] = None```) and add check in if statment. ## 馃 Your Feedback is Valued I appreciate your time in reviewing this PR, and I'm looking forward to any feedback or suggestions you might have. If you have any questions or need further clarification, please don't hesitate to reach out. I'll be more than happy to assist. Thank you once again for considering this contribution to the project! Let's continue working together to make our admin interface even better! 馃槉 Best regards, datatab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 馃憢,
I hope you're doing great! I'm delighted to submit this pull request for enhancing the admin interface #2849 by adding the ability to change the display name of users.
馃専 Changes Made
Below is a summary of the changes I've made in this PR:
FRONTEND:
[id].tsx- removeisDisabledfrom FormControl.oasst_api_client.ts- change API PUT url inset_user_statusmethod to acceptdisplay_nameparameter.update_user.tsxadddisplay_nameparameter.BACKEND:
user.py-> updateupdate_userfunction signature *(addeddisplay_name: Optional[str] = None)user_repository.pyupdateupdate_userfunction signature *(addeddisplay_name: Optional[str] = None) and add check in if statment.馃 Your Feedback is Valued
I appreciate your time in reviewing this PR, and I'm looking forward to any feedback or suggestions you might have. If you have any questions or need further clarification, please don't hesitate to reach out. I'll be more than happy to assist.
Thank you once again for considering this contribution to the project! Let's continue working together to make our admin interface even better! 馃槉
Best regards,
datatab.