Updated SODA to use DatasetEntry #2913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardikyagnik
requested review from
theblackcat102,
sanagno,
dvruette,
andreaskoepf and
yk
as code owners
CloseChoice
approved these changes
Apr 26, 2023
|
LGTM, thanks |
andreaskoepf
approved these changes
Apr 27, 2023
grgau
pushed a commit
to grgau/Open-Assistant
that referenced
this pull request
May 8, 2023
Issue: LAION-AI#2827 Updated `SODA` class to use DatasetEntry which generalises the data and provides consistent data structure to store and access Q&A pairs. Changes includes - Updated SODA class to store Q/A pairs as DatasetEntry object. - Updated the `__getitem__` function to return DatasetEntry object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2827
Updated
SODAclass to use DatasetEntry which generalises the data and provides consistent data structure to store and access Q&A pairs.Changes includes
__getitem__function to return DatasetEntry object