Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFT training #301

Merged
merged 1 commit into from Jan 3, 2023
Merged

SFT training #301

merged 1 commit into from Jan 3, 2023

Conversation

sanagno
Copy link
Collaborator

@sanagno sanagno commented Jan 3, 2023

Base code for SFT pretraining. Currently, it is mostly a placeholder code. Will be adapted based on the format of the human generated data.

Copy link
Collaborator

@yk yk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, lgtm

@yk yk merged commit cc57158 into LAION-AI:main Jan 3, 2023
@mrcabbage972
Copy link
Contributor

mrcabbage972 commented Jan 5, 2023

For this to support bigger models in any scenario that isn't a single gigantic GPU, I'd change the code to load the model with HF Accelerate and also use the 8-bit quantization from bitsandbytes. If ya'll are interested, I could open a PR for this simple change.

@sanagno
Copy link
Collaborator Author

sanagno commented Jan 5, 2023

That would be great, I am already looking into this but feel free to start with the PR.

@mrcabbage972
Copy link
Contributor

mrcabbage972 commented Jan 5, 2023

Cool, I'll work on this over the weekend.

@sanagno
Copy link
Collaborator Author

sanagno commented Jan 6, 2023

@mrcabbage972 see also the latest PR #452 and #456.

Feel free to edit.

@mrcabbage972
Copy link
Contributor

mrcabbage972 commented Jan 8, 2023

Thanks, I see that @theblackcat102 already started working on 8-bit quantization in #456.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants