Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit hook black->black-jupyter #304

Merged
merged 4 commits into from Jan 3, 2023
Merged

pre-commit hook black->black-jupyter #304

merged 4 commits into from Jan 3, 2023

Conversation

janosh
Copy link
Contributor

@janosh janosh commented Jan 3, 2023 •
edited

black supports formatting Jupyter notebooks.

This PR does not include the changes that would result from

pre-commit run black-jupyter --all-files

Happy to add them if this gets approval.

yk
yk approved these changes Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@yk yk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@yk yk enabled auto-merge January 3, 2023 07:51
auto-merge was automatically disabled January 3, 2023 14:40

Head branch was pushed to by a user without write access

@janosh
Copy link
Contributor Author

janosh commented Jan 3, 2023

@yk I removed the notebooks exclusion from .pre-commit-config.yaml.

yk
yk approved these changes Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@yk yk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@yk yk merged commit c14f86e into LAION-AI:main Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitplane bitplane bitplane approved these changes

@yk yk yk approved these changes

@andreaskoepf andreaskoepf Awaiting requested review from andreaskoepf andreaskoepf is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@janosh @bitplane @yk