Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add requests to requirements.txt #3113

Merged
merged 1 commit into from May 11, 2023
Merged

add requests to requirements.txt #3113

merged 1 commit into from May 11, 2023

Conversation

ComradeEcho
Copy link
Contributor

The backends were exiting due to missing requests

image

andreaskoepf
andreaskoepf approved these changes May 11, 2023
View reviewed changes
Copy link
Collaborator

@andreaskoepf andreaskoepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally we have fixed versions for all dependencies. Maybe requests is stable enough to omit it.

@ComradeEcho
Copy link
Contributor Author

Normally we have fixed versions for all dependencies. Maybe requests is stable enough to omit it.

If you decide to opt for a fixed version of requests, there's another instance of it here added last week:

Open-Assistant/backend/requirements.txt

Line 18 in ea6af41

requests

@andreaskoepf andreaskoepf merged commit 354cb6e into LAION-AI:main May 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaskoepf andreaskoepf andreaskoepf approved these changes

@melvinebenezer melvinebenezer Awaiting requested review from melvinebenezer melvinebenezer is a code owner

@yk yk Awaiting requested review from yk yk is a code owner

Assignees
No one assigned
Labels
inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ComradeEcho @andreaskoepf