Feat/better messages #318
Merged
Feat/better messages #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM so far, thank you very much! @andreaskoepf I'll leave approval to you |
|
this also fixes a bug where I was sending ranking responses as a |
andreaskoepf
approved these changes
Jan 3, 2023
discord-bot/.env.example
Outdated
| @@ -1,7 +1,7 @@ | |||
| BOT_TOKEN=<discord bot token> | |||
| DECLARE_GLOBAL_COMMANDS=<testing guild id> | |||
| OWNER_IDS=[<your user id>, <other user ids>] | |||
| PREFIX="./" | |||
| PREFIX="/" # DO NOT LEAVE EMPTY | |||
There was a problem hiding this comment.
I suggest also to add a validator in the pydantic settings class, e.g. see https://docs.pydantic.dev/usage/validators/
| # A `dict[hikari.Message | None, UUID | None]]` that maps user IDs to (task msg ID, task UUIDs). | ||
| # Either both are `None` or both are not `None`. | ||
| # If both are `None`, the user is not currently selecting a task. | ||
| # TODO: Grow this on startup so we don't have to re-allocate memory every time it needs to grow |
There was a problem hiding this comment.
This is in general not necessary (premature optimization).
There was a problem hiding this comment.
I agree, it's just a reminder for the future. Should I change "TODO" to some other word?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few things that changed in this PR
discord-bot/bot/messages.py