Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic implementation of robust message revision proposal system #3289

Closed
wants to merge 24 commits into from

Conversation

gabrielmfern
Copy link

@gabrielmfern gabrielmfern commented Jun 3, 2023

Hello, this is the pull request intending to implement a basic editing system.

The revision proposal system I am planning to write is going to include the following features (as mentioned in #3185):

  • Being able to visualize the proposed revisions
  • Public proposal of revisions to any message
  • Revisions can be proposed by anyone
  • Revisions should be editable, and once edited its reviews should be cleared
  • The revisions should have a "review" process (similar to github)
    • An author has to be able to make a revision to his message without any review if and only if the message has no labels
    • Reviews should have a comment section where the reviewer can start with some kind of comment to the user proposing the review
    • Reviews should be cleared once if a revision's content is edited
    • Mods should be notified to approve or disapprove a revision if the reviews are split
      • Mods should have a way to approve or disapprove a revision without the approval of others
    • Should add a task in the dashboard to review a message's revision and if the message had enough labels to be exported only the people that labelled it should be required to review it (but still allow anyone to review it)

Current changes

  • A new route with a very basic interface that shows the proposed revisions of a certain message pulled from the back-end and database.
  • A new route to propose a revision to a certain message with the back-end done as well but still missing a button to navigate the user there.

image


My discord username is gabrielmfern if anyone anyone wants to discuss something in more detail directly with me

@github-actions
Copy link

github-actions bot commented Jun 3, 2023

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@gabrielmfern gabrielmfern marked this pull request as draft June 3, 2023 13:00
@andrewm4894
Copy link
Collaborator

was going to ask if edits will be stored and tracked and looks like you thinking yes - this is cool as this could actually end up being very high quality metadata for various use cases.

love idea of edits being almost like git diffs in some ways.

@AbdBarho
Copy link
Collaborator

AbdBarho commented Jun 3, 2023

Thank you, please keep in mind that other contributor is working on something that touches upon this work here #3280

Feel free to get in touch on discord to coordinate

@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

1 similar comment
@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@olliestanley olliestanley linked an issue Jun 12, 2023 that may be closed by this pull request
@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

1 similar comment
@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@gabrielmfern gabrielmfern changed the title Basic implementation of editing system both in front-end and back-end Basic implementation of robust message revision proposal system Jun 17, 2023
@gabrielmfern
Copy link
Author

Couldn't get to coding this month because I am moving, but I will get back to work on this PR from now on because I am somewhat stable. The work I can put on this is basically weekly, something like 2 days of the week, but I have not left this PR behind. If someone is interested in helping me finish the PR sooner I can add you to the contributors on my OA fork.

@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants