Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devcontainer improvements #333

Merged
merged 18 commits into from Jan 3, 2023

Conversation

andrewm4894
Copy link
Collaborator

@andrewm4894 andrewm4894 commented Jan 3, 2023

playing around with similar idea to this PR. #327

changes:

  • make devcontainer more generic as opposed to launching into any specific service.
  • add readme to .devcontainer folder with some example usage.
  • ensure pre-commit is installed and available in dev container.
  • validate that docker compose up --build works from within the codespace.

@andrewm4894
Copy link
Collaborator Author

image

@andrewm4894
Copy link
Collaborator Author

image

@yk
Copy link
Collaborator

yk commented Jan 3, 2023

hey this is awesome. do you think you could also tell people about this in the main README? or at least drop a hint there with a link to the readme you wrote?

@andrewm4894
Copy link
Collaborator Author

hey this is awesome. do you think you could also tell people about this in the main README? or at least drop a hint there with a link to the readme you wrote?

yep will do, will add a one liner and link. just was hesitant to add too much myself into the main readme but agree makes sense to reference it - will do in a few mins

@andrewm4894
Copy link
Collaborator Author

@yk done

Copy link
Collaborator

@yk yk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you!

@andrewm4894 andrewm4894 merged commit 1cc0eec into LAION-AI:main Jan 3, 2023
@andrewm4894 andrewm4894 deleted the devcontainer-improvements branch January 4, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants