#307 new page to display recent messages #375
Conversation
jojopirker
requested review from
fozziethebeat,
k-nearest-neighbor and
AbdBarho
as code owners
jojopirker
changed the title
| name={`${item.isAssistant ? "Assitant" : "User"}`} | ||
| src={`${item.isAssistant ? "/logos/logo.png" : "/images/temp-avatars/av1.jpg"}`} | ||
| /> | ||
| <Box className={`p-4 rounded-md text-white whitespace-pre-wrap ${bgColor} text-white w-full`}>{item.text}</Box> |
There was a problem hiding this comment.
does this work in dark mode?
There was a problem hiding this comment.
| borderRadius="xl" | ||
| className="p-6 shadow-sm" | ||
| > | ||
| {isLoading ? ( |
There was a problem hiding this comment.
could you please move the isLoading check to the parent component?
There was a problem hiding this comment.
Screen.Recording.2023-01-04.at.20.05.16.mov
sure, i just had it in there to show small spinners... but could also change it to show a loading screen
There was a problem hiding this comment.
now removed... but still looks the same :)
| method: "GET", | ||
| headers: { | ||
| "X-API-Key": process.env.FASTAPI_KEY, | ||
| "Content-Type": "application/json", |
There was a problem hiding this comment.
you arguably don't need content-type of a GET because it has no body.
website/src/pages/messages/index.tsx
Outdated
| ); | ||
| }; | ||
|
|
||
| MessagesDashboard.getLayout = (page) => ( |
There was a problem hiding this comment.
is this layout used somewhere else? I remember seeing something similar, if you find a similar layout please move it to its own component
|
Can you make the padding between the title and div consistent with the widgets on the dashboard? |
There was a problem hiding this comment.
It looks like all the other requested changes have been made. I approve but won't merge until @AbdBarho gets a chance to look again.
spacing for message dashboard (comment in #375)
Initial implementation for #307.
Looks like this now:
Unfortunately the flagging currently does not work..