Style Empty State and 404 #695
Conversation
Decreased padding for mobile and changed some styling to give better contrast
last commit
rsandb
requested review from
fozziethebeat,
k-nearest-neighbor and
AbdBarho
as code owners
…/Open-Assistant into Style-Empty-State-and-404
Updating the 404 and 500 pages to provide a link to github issues
…on-not-responsive website: Fix responsiveness of '...' in sortable item
website/src/pages/404.tsx
Outdated
| <Box bg={backgroundColor} p="10" borderRadius="xl" shadow="base"> | ||
| <Box display="flex" flexDirection="column" alignItems="center" gap="8"> | ||
| <FiAlertTriangle size="30" color="DarkOrange" /> | ||
| <Box display="flex" flexDirection="column" alignItems="center" gap="3"> |
There was a problem hiding this comment.
would make sense to have EmptyState accept children so you can re-use it here?
There was a problem hiding this comment.
I agree, EmptyState should be a more generic component that takes in children.
There was a problem hiding this comment.
I think this is sufficient for now and a fairly large PR. my request is to make a follow up PR to make EmptyState a re-usable component and update only other components using EmptyState.
website: Make the more text button clearer
website/src/pages/404.tsx
Outdated
| <Box display="flex" flexDirection="column" alignItems="center" gap="8"> | ||
| <FiAlertTriangle size="30" color="DarkOrange" /> | ||
| <Box display="flex" flexDirection="column" alignItems="center" gap="3"> | ||
| <Text>Sorry, the page you are looking for does not exist.</Text> |
There was a problem hiding this comment.
Can you merge in my changes? I added in a button to file a bug here.
website/src/pages/404.tsx
Outdated
| <Box bg={backgroundColor} p="10" borderRadius="xl" shadow="base"> | ||
| <Box display="flex" flexDirection="column" alignItems="center" gap="8"> | ||
| <FiAlertTriangle size="30" color="DarkOrange" /> | ||
| <Box display="flex" flexDirection="column" alignItems="center" gap="3"> |
There was a problem hiding this comment.
I agree, EmptyState should be a more generic component that takes in children.
|
Also, if you're feeling motivated, I added a |
Is it just in the pages dir? I can't find it |
Message Styling For Mobile
…/Open-Assistant into Style-Empty-State-and-404
Update styling to match rest of app