website: Add localization to pages, header and footer #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix import orders for useTranslation Apply common translations for header and footer lint Fix getServerSideProps messages/id
rjmacarthy
requested review from
fozziethebeat,
k-nearest-neighbor and
AbdBarho
as code owners
rjmacarthy
changed the title
AbdBarho
reviewed
Jan 19, 2023
fozziethebeat
requested changes
Jan 20, 2023
|
❌ pre-commit failed. |
fozziethebeat
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, this is a follow up PR for #779 which includes the following changes:
i18nprovider for server side rendered pages usingcommonnamespace.commonnamespace.Unfortunately its necessary to call
serverSideTranslationson each page level component see https://github.com/i18next/next-i18next#serversidetranslations for more information.Please let me know if you have any questions or concerns.