Restyle account page #858
Merged
Restyle account page #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdBarho
requested review from
fozziethebeat and
k-nearest-neighbor
as code owners
notmd
reviewed
Jan 20, 2023
| const backgroundColor = useColorModeValue("white", "gray.700"); | ||
|
|
||
| const BoxClasses: BoxProps = { | ||
| gap: "2", | ||
| borderRadius: "xl", | ||
| shadow: "base", | ||
| className: "p-4 sm:p-6", | ||
| className: "p-4 sm:p-6 " + (props.className ?? ""), |
There was a problem hiding this comment.
You can use clsx here to simplify the code
notmd
reviewed
Jan 20, 2023
| import Head from "next/head"; | ||
| import Link from "next/link"; | ||
| import { useSession } from "next-auth/react"; | ||
| import React from "react"; | ||
| export { getDefaultStaticProps as getStaticProps } from "src/lib/default_static_props"; | ||
| import { MdOutlineEdit } from "react-icons/md"; |
There was a problem hiding this comment.
We are trying to use one type of icon. Can you switch to Feather icon here?
There was a problem hiding this comment.
I am not sure we talked about that.
is Feather icon installed ?
I will leave it to a different PR anyway
There was a problem hiding this comment.
I've been using Font Awesome (react-icons/fa) but they don't don't have an outline edit icon. I think this is okay for now.
fozziethebeat
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #747