Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lang-tag based task selection (lang-separation) #863

Merged
merged 4 commits into from Jan 20, 2023

Conversation

andreaskoepf
Copy link
Collaborator

  • ConversationMessage, TextReplyToMessage and TaskRequest now have lang property, if no value is provided 'en' is assumed
  • POST api/v1/tasks/availability endpoint has a lang param
  • default for lang column of message table is now 'en' (was 'en-US')
  • task selection in TreeManager is language-dependent

@andreaskoepf andreaskoepf requested a review from yk as a code owner January 20, 2023 14:05
@andreaskoepf andreaskoepf changed the title Add lang-tag based task selection Add lang-tag based task selection (lang-separation) Jan 20, 2023
Copy link
Collaborator

@yk yk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really cool, thank you.
It may be worth to think about always considering a set of languages, instead of only one, i.e. a user could ask for a task in either of their languages, and a task could be appropriate for either of two languages (i.e. translate from one to the other, or some math quiz, etc.).

but up to you

@andreaskoepf
Copy link
Collaborator Author

It may be worth to think about always considering a set of languages, instead of only one, i.e. a user could ask for a task in either of their languages, and a task could be appropriate for either of two languages (i.e. translate from one to the other, or some math quiz, etc.).

For task selection that is a future option. For submission of the message I would suggest to use only a single language tag(even when multiple languages are mixed). When the uses has more than one active language it would be necessary to specify the language used for a submission ... or to use the task's language as default.

Translation is a use-case, but a special one that won't even be solved by using a list of languages, e.g. like instruction: "Translate this text into Chinese: ..." .. while the instruction-message would be in "en" the task could only be fulfilled by users with "en" + "zh-cn" or similar, so somehow the user would need to specify the desired language of the reply.

I think we should first try the simple solution of 'single language set per session" which will be an improvement for 95% of all use-cases.

@yk
Copy link
Collaborator

yk commented Jan 20, 2023

sounds good

@andreaskoepf
Copy link
Collaborator Author

link #854

@andreaskoepf andreaskoepf merged commit 2d21b65 into main Jan 20, 2023
@andreaskoepf andreaskoepf deleted the 854_lang_tag_backend branch January 20, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants