website: Add locale to Leaderboard and organize locale files #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmacarthy
requested review from
fozziethebeat,
k-nearest-neighbor and
AbdBarho
as code owners
fozziethebeat
approved these changes
Jan 21, 2023
|
We had a merge that affects one of the files you changed. Please resolve that conflict then I'll merge it. |
fozziethebeat
requested changes
Jan 21, 2023
There was a problem hiding this comment.
Testing on main I see a lot of issues. I made a bug that needs to be addressed before this is submitted: #870
rjmacarthy
force-pushed
the
chore/leaderboard-locales
branch
from
61a7b16
to
edeae8c
Compare
|
❌ pre-commit failed. |
fozziethebeat
approved these changes
Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another follow up PR for localization. New locales have been applied to the Leaderboard page and some keys have been re-arranged in order to re-use the common ones.
If you have any questions or concerns please let me know.