Ensuring localization works everywhere and fix an admin view #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fozziethebeat
requested review from
k-nearest-neighbor and
AbdBarho
as code owners
|
Please also add to https://github.com/LAION-AI/Open-Assistant/blob/main/website/src/pages/tasks/all.tsx file aswell. I closed my PR fixing in favor of this. |
Done~ |
rjmacarthy
approved these changes
Jan 21, 2023
AbdBarho
approved these changes
Jan 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures every page has the localization properties needed to avoid rehydration issues during some page transitions.
Also fixes a breaking change in the backend API for fetching user information
Precursor to #854