Typesafe i18n #887
Merged
Typesafe i18n #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
notmd
commented
Jan 22, 2023
notmd
commented
- Setup Typescript support for i18n
- Add missing translation
notmd
requested review from
fozziethebeat,
k-nearest-neighbor and
AbdBarho
as code owners
notmd
commented
Jan 22, 2023
| @@ -20,7 +20,6 @@ import { FiAlertTriangle, FiLayout, FiLogOut, FiSettings, FiShield } from "react | |||
| interface MenuOption { | |||
| name: string; | |||
| href: string; | |||
| desc: string; | |||
There was a problem hiding this comment.
I delete it because it isn't used anywhere
AbdBarho
reviewed
Jan 22, 2023
| </Text> | ||
| <Text as="p" className={`mt-4 text-sm ${textColorClass}`}> | ||
| {t(`faq_items.a${index}`)} | ||
| {t(`faq_items.a${index as 0}`)} |
There was a problem hiding this comment.
oof! do we need to cast to a literal?
There was a problem hiding this comment.
Yes, otherwise TS will complain
fozziethebeat
approved these changes
Jan 22, 2023
|
Will merge once the conflict has been resolved |
notmd
commented
Jan 23, 2023
fozziethebeat
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.