-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More Info screen improvement #200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall really nice design, I just one small remark: you can use enum functions to display text, you shouldn't pass lambda all the way down.
@@ -52,7 +52,7 @@ fun MoreInfoScreen( | |||
// contains the top icon buttons | |||
item { TopBar(navigateBack) } | |||
// displays activity title and duration | |||
item { ActivityTitleZone(activityToDisplay) } | |||
item { ActivityTitleZone(activityToDisplay, processDiffText) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to pass lambda, you can use the enum defined functions, either .name or toString()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes ! Ready for merging :)
|
Changed the UI design of the
![WhatsApp Image 2024-05-02 at 15 49 51](https://private-user-images.githubusercontent.com/100190035/327457597-21d5950d-624b-4877-942e-90fb02e79d39.jpeg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxMDA2NjUsIm5iZiI6MTcyNjEwMDM2NSwicGF0aCI6Ii8xMDAxOTAwMzUvMzI3NDU3NTk3LTIxZDU5NTBkLTYyNGItNDg3Ny05NDJlLTkwZmIwMmU3OWQzOS5qcGVnP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MTJUMDAxOTI1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZTYyNTY1ZjkwNTJhYzNkYWQyMWNlOGU1ZDI0ZGNiMTMxNmEyNWNlODgzOGU2ZDRjNzM3MTI1YzQwMzQ1Y2YyNCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.GpF_CbeOKbVZ5T0QzGmvGaRLKfU4xquMg8KZAc02VF4)
More Info
screen to comply with figma, including a system to display the rating with empty, semi-filled and filled stars