Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range Search Screen #305

Merged
merged 9 commits into from
May 24, 2024
Merged

Range Search Screen #305

merged 9 commits into from
May 24, 2024

Conversation

JoniDutoit
Copy link
Contributor

@JoniDutoit JoniDutoit commented May 23, 2024

Overview

This PR aims to continue the creation of the radius search feature for finding activities. Actually, since this is quite an important feature for the application, enhancing it will bring the discover screen to the next level! Merging this PR will improve the radius search feature, making it more visually appealing and interactive.

Changes

Before After
  • Before: the RangeSearch feature was invoked by a ModalBottomSheet where you could chose your radius without visualization of the selected area,
  • After: now, the RangeSearch has become a screen of it's own! Thus, when clicking on the location, now the users are sent to a new interactive screen, composed of a map and a slider to select the desired range between 10-30km .

Results

Screen_recording_20240523_185801.mp4

Testing

86% line coverage now. I still have the intention of getting extra line coverage for the RangeSearchScreen if we can allocate time for enhancing line coverage in the future.

What's next

  • Implementing a button to use the current user's location that should be displayed in the RangeSearchScreen by a marker icon could be a nice idea !
  • Making clusters for activities instead of using activities icons
  • Displaying all activities beforehand instead of only seeing listed activities when selecting the radius

@JoniDutoit JoniDutoit linked an issue May 23, 2024 that may be closed by this pull request
@Andy130604 Andy130604 added this to the Milestone 4 milestone May 23, 2024
Copy link

sonarcloud bot commented May 23, 2024

@Andy130604 Andy130604 self-requested a review May 23, 2024 22:11
Copy link
Contributor

@Andy130604 Andy130604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a nice feature and was touching so many small files and you still managed to write tests for all the cases. Hats off for your work!

}
}
}
Canvas(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the first time we use this composable. Nice implementation, I like it!

Copy link
Contributor

@ecornamu ecornamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done implementing this upgrade ! Everything looks good to me

@JoniDutoit JoniDutoit merged commit 390adc2 into main May 24, 2024
3 checks passed
@JoniDutoit JoniDutoit deleted the map/rangeSearch branch May 24, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RangeSearch interacts with the map
3 participants